-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added save and copyToClipboard Buttons #1
Open
venukommu
wants to merge
7
commits into
BloomBooks:master
Choose a base branch
from
venukommu:Adding-Save-and-Copy-To-Clipboard-Buttons
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Added save and copyToClipboard Buttons #1
venukommu
wants to merge
7
commits into
BloomBooks:master
from
venukommu:Adding-Save-and-Copy-To-Clipboard-Buttons
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hatton
requested changes
Aug 26, 2020
Dear John Hatton,
I have fixed the typo issues you have highlighted and also few other minor
issues we have noticed in our testing. Please check the committed code and
let me know if you have any suggestions.
Regarding Installer,
I need your guidance to make MSI Installer for this application. The Exe
file is working fine as expected, I have been trying to make an MSI package
using that working exe and dependent files. But after installation using
the installer, we are not able to open/run the application and it is
not opening anything when we are trying to open the application either
Programs menu or Desktop shortcut.
I have followed four methods including 3rd party applications to make
installers, but nothing is working as expected. I have included Bob Eaton
also here, appreciate if anyone can help me to sortout this issue.
Thank you for all your help and guidance.
-------------------------------------
Thanks and Regards
*VENU KOMMU*
*Project Manager*
bayLogic Technologies | Simplifying Enterprise Solutions
+91 - 90 104 10 104 | [email protected]
[email protected] | www.baylogictech.com
Maharanipeta | Visakhaptnam | Andhra Pradesh | India | PIN:530017
"Live Simply, Love Generously, Care Deeply,
Speak Kindly, Leave the rest to GOD......"
…On Thu, Aug 27, 2020 at 3:44 AM John Hatton ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In ImageGalleryClient/Form1.cs
<#1 (comment)>
:
> - {
- this._imageGalleryControl.GetImage().Save(dialog.FileName);
- }
- }
- }
+ this.clipboardButton.Enabled = this.saveButton.Enabled = false;
+ }
+ void onImageChanged(object sender, EventArgs e)
+ {
+ this.clipboardButton.Enabled = this.saveButton.Enabled = this._imageGalleryControl.GetImage() != null;
+ }
+ private void OnSaveClick(object sender, EventArgs e)
+ {
+ if (this._imageGalleryControl.GetImage() == null)
+ {
+ MessageBox.Show("Please choose atleast one image");
Typo in "atleast". Missing fullstop at the end.
------------------------------
In ImageGalleryClient/ImageGalleries.csproj.user
<#1 (comment)>
:
> @@ -0,0 +1,16 @@
+<?xml version="1.0" encoding="utf-8"?>
You don't want to commit .user files to repos. Should be removed using an
entry in .gitignore
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHPERKZ7HPFXBU673J5XV2DSCWCNRANCNFSM4QJQSEHQ>
.
|
Chances are some dependency is missing.
Check out this blob that has some good advice:
https://www.raymond.cc/blog/check-what-dll-or-ocx-dependency-files-is-needed-for-a-software/
I’ve always used the 1st one he mentions, but lately I’ve noticed it takes forever to load and hasn’t been that useful for .net type applications.
HTHs,
Bob
From: Venu Kommu [mailto:[email protected]]
Sent: Friday, August 28, 2020 1:06 AM
To: BloomBooks/SampleImageGalleryClient <[email protected]>
Cc: BloomBooks/SampleImageGalleryClient <[email protected]>; Author <[email protected]>; Matt A <[email protected]>; Ravi Pasupuleti <[email protected]>; Padma Kanakala <[email protected]>; Lalit Kumar <[email protected]>; Bob Eaton <[email protected]>
Subject: Re: [BloomBooks/SampleImageGalleryClient] Added save and copyToClipboard Buttons (#1)
Dear John Hatton,
I have fixed the typo issues you have highlighted and also few other minor issues we have noticed in our testing. Please check the committed code and let me know if you have any suggestions.
Regarding Installer,
I need your guidance to make MSI Installer for this application. The Exe file is working fine as expected, I have been trying to make an MSI package using that working exe and dependent files. But after installation using the installer, we are not able to open/run the application and it is not opening anything when we are trying to open the application either Programs menu or Desktop shortcut.
I have followed four methods including 3rd party applications to make installers, but nothing is working as expected. I have included Bob Eaton also here, appreciate if anyone can help me to sortout this issue.
Thank you for all your help and guidance.
-------------------------------------
Thanks and Regards
VENU KOMMU
Project Manager
bayLogic Technologies | Simplifying Enterprise Solutions
+91 - 90 104 10 104 | <mailto:[email protected]> [email protected]
<mailto:[email protected]> [email protected] | <http://www.baylogictech.com/> www.baylogictech.com
Maharanipeta | Visakhaptnam | Andhra Pradesh | India | PIN:530017
"Live Simply, Love Generously, Care Deeply,
Speak Kindly, Leave the rest to GOD......"
On Thu, Aug 27, 2020 at 3:44 AM John Hatton <[email protected] <mailto:[email protected]> > wrote:
@hatton requested changes on this pull request.
_____
In ImageGalleryClient/Form1.cs <#1 (comment)> :
- {
- this._imageGalleryControl.GetImage().Save(dialog.FileName);
- }
- }
- }
+ this.clipboardButton.Enabled = this.saveButton.Enabled = false;
+ }
+ void onImageChanged(object sender, EventArgs e)
+ {
+ this.clipboardButton.Enabled = this.saveButton.Enabled = this._imageGalleryControl.GetImage() != null;
+ }
+ private void OnSaveClick(object sender, EventArgs e)
+ {
+ if (this._imageGalleryControl.GetImage() == null)
+ {
+ MessageBox.Show("Please choose atleast one image");
Typo in "atleast". Missing fullstop at the end.
_____
In ImageGalleryClient/ImageGalleries.csproj.user <#1 (comment)> :
@@ -0,0 +1,16 @@
+<?xml version="1.0" encoding="utf-8"?>
You don't want to commit .user files to repos. Should be removed using an entry in .gitignore
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#1 (review)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHPERKZ7HPFXBU673J5XV2DSCWCNRANCNFSM4QJQSEHQ> . <https://github.com/notifications/beacon/AHPERK7I2FAOBRDBRZGRT53SCWCNRA5CNFSM4QJQSEH2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODRO5VKY.gif>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added save and copyToClipboard Buttons